Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: macOS w/ m1(arm64) for curl build and testing #9565

Closed
wants to merge 3 commits into from
Closed

CI: macOS w/ m1(arm64) for curl build and testing #9565

wants to merge 3 commits into from

Conversation

pheiduck
Copy link
Contributor

@pheiduck pheiduck commented Sep 21, 2022 •
edited

normal and debug builds.
more will be added in next PR.

@pheiduck pheiduck marked this pull request as draft September 21, 2022 18:48
@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 21, 2022 •
edited

@bagder @mback2k
I need some feedback for this, let me know what you think about this CI implementation.
Thank you! :)

@pheiduck
Copy link
Contributor Author

m1 (arm64) complie works now 🎉

@pheiduck pheiduck marked this pull request as ready for review September 22, 2022 08:15
@pheiduck pheiduck changed the title CI: macOS w/ m1 for curl build and testing CI: macOS w/ m1 for curl build and testing (arm64) Sep 22, 2022
@pheiduck pheiduck mentioned this pull request Sep 22, 2022
Closed
@pheiduck pheiduck changed the title CI: macOS w/ m1 for curl build and testing (arm64) CI: macOS w/ m1(arm64) for curl build and testing Sep 22, 2022
@pheiduck
Copy link
Contributor Author

@bagder CI looks good now 👍

@vszakats vszakats added the CI Continuous Integration label Sep 22, 2022
@bagder bagder requested a review from mback2k September 23, 2022 07:09
@pheiduck
Copy link
Contributor Author

@bagder maybe we could also find a workaround for openldap so that we don't have to use the build flags: --disable-ldap --disable-ldaps.

@bagder
Copy link
Member

bagder commented Sep 23, 2022

@bagder maybe we could also find a workaround for openldap so that we don't have to use the build flags: --disable-ldap --disable-ldaps.

What happens if you you remove them?

@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 23, 2022 •
edited

What happens if you you remove them?

You can see it here: https://cirrus-ci.com/task/5899470490566656
There are some deprecations in ldap.c and ldap.h -> XCode
We could implement a function --without-ldap?

@bagder
Copy link
Member

bagder commented Sep 24, 2022

Ah, I've seen those ldap deprecation warnings on "regular" macOS builds too...

@pheiduck
Copy link
Contributor Author

Ah, I've seen those ldap deprecation warnings on "regular" macOS builds too...

It works with: CFLAGS: "-Wno-vla -mmacosx-version-min=10.9" which we use on "regular" macOS builds as well.

@pheiduck
Copy link
Contributor Author

Finally let me know if you what some fine tuning. But for now it’s ready for review/merge

mback2k
mback2k reviewed Sep 24, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
mback2k
mback2k reviewed Sep 24, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
mback2k
mback2k reviewed Sep 24, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
@mback2k
Copy link
Member

mback2k commented Sep 24, 2022

Thanks for your contribution @pheiduck. I got some minor comments you may want to look at before this is merged.

@pheiduck
macOS CI with m1 for curl build and testing
3981826 
Signed-off-by: Philip H <47042125+pheiduck@users.noreply.github.com>
@pheiduck
Copy link
Contributor Author

Thanks for your contribution @pheiduck. I got some minor comments you may want to look at before this is merged.

@mback2k done. It only fails now because the branch is not in sync with the upstream due to rebase. All problems have been fixed so that the CI runs stable.

@pheiduck
Copy link
Contributor Author

And yes we could it also simplify like the windows task, but maybe on a next PR. ;)

mback2k
mback2k approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@mback2k mback2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bagder
Copy link
Member

bagder commented Sep 29, 2022

Thanks!

@bagder bagder closed this in 55becae Sep 29, 2022
@pheiduck pheiduck deleted the cirrus/m1 branch September 30, 2022 17:19
@pheiduck pheiduck mentioned this pull request Sep 30, 2022
Closed
This was referenced Oct 9, 2022
Closed
Closed
mback2k pushed a commit that referenced this pull request Oct 15, 2022
@pheiduck @mback2k
cirrus-ci: add more macOS builds with m1 based on x86_64 builds
1de60b1 
Also refactor macOS builds to use task matrix.

Assisted-by: Marc Hörsken
Closes #9565
mback2k added a commit to mback2k/curl that referenced this pull request Oct 15, 2022
@mback2k
CI/cirrus: remove superfluous double-quotes and sudo
7216deb 
Follow up to curl#9565 and curl#9677
@mback2k mback2k mentioned this pull request Oct 15, 2022
Closed
mback2k added a commit to mback2k/curl that referenced this pull request Oct 17, 2022
@mback2k
CI/cirrus: remove superfluous double-quotes and sudo
d101dd3 
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit to mback2k/curl that referenced this pull request Oct 18, 2022
@mback2k
CI/cirrus: remove superfluous double-quotes and sudo
e560701 
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit to mback2k/curl that referenced this pull request Oct 20, 2022
@mback2k
CI/cirrus: remove superfluous double-quotes and sudo
e8f5c0a 
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit to mback2k/curl that referenced this pull request Oct 24, 2022
@mback2k
CI/cirrus: remove superfluous double-quotes and sudo
6e25b55 
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit that referenced this pull request Oct 30, 2022
@mback2k
CI/cirrus: remove superfluous double-quotes and sudo
65bdd6b 
Follow up to #9565 and #9677
Closes #9738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mback2k mback2k mback2k approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pheiduck @bagder @mback2k @vszakats