windows: add .rc support to autotools builds #9521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
|
There is a warning |
vszakats
changed the title
|
CI seems fine now, with two unrelated (flaky?) single-test failures @ AppVeyor, and |
|
FWIW, tried removing ¯\(ツ)/¯ |
|
A side effect of this commit is new warning messages from I tried locally to move the |
|
@monnerat: Great find! This also fixes the odd warning noted here earlier, and in my tests the .rc files continue to compile and link fine. Do you want to commit the fix? [ Strangely, I'm not getting those |
No, I let you care of your baby !
libtool or autotools version dependent ? OS dependent ? who knows ! |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 23, 2022
Follow up to 6de7322 Ref: curl#9521 (comment) Suggested-by: Patrick Monnerat Closes #xxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 23, 2022
- Fix warnings when running `autoreconf -fi`. - Fix warning when compiling .rc files: ``` libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag' ``` Follow up to 6de7322 Ref: curl#9521 (comment) Suggested-by: Patrick Monnerat Closes #xxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 23, 2022
Move `LT_LANG([Windows Resource])` after `XC_LIBTOOL`. This fixes: - Warnings when running `autoreconf -fi`. - Warning when compiling .rc files: libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag' Follow up to 6de7322 Ref: curl#9521 (comment) Suggested-by: Patrick Monnerat Closes #xxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 23, 2022
Move `LT_LANG([Windows Resource])` after `XC_LIBTOOL`, fixing: - Warnings when running `autoreconf -fi`. - Warning when compiling .rc files: libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag' Follow up to 6de7322 Ref: curl#9521 (comment) Suggested-by: Patrick Monnerat Closes #xxxx
|
Sure, I've opened a PR.
The perfect motto for autotools :) (to be fair: for build systems in general) |
vszakats
added a commit
that referenced
this pull request
Sep 23, 2022
Move `LT_LANG([Windows Resource])` after `XC_LIBTOOL`, fixing: - Warnings when running `autoreconf -fi`. - Warning when compiling .rc files: libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag' Follow up to 6de7322 Ref: #9521 (comment) Suggested-by: Patrick Monnerat Closes #9582
|
Thanks for fix. |
jquepi
pushed a commit
to jquepi/curl.1.555
that referenced
this pull request
Oct 24, 2022
Move `LT_LANG([Windows Resource])` after `XC_LIBTOOL`, fixing: - Warnings when running `autoreconf -fi`. - Warning when compiling .rc files: libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag' Follow up to 6de7322c03d5b4d91576a7d9fc893e03cc9d1057 Ref: curl/curl#9521 (comment) Suggested-by: Patrick Monnerat Closes #9582
|
The latest release fails to build, could this be related? @vszakats |
|
@lazka: Definitely related. So far no idea what may be happening. Here's a relevant log from the 7.86.0 release commit CI run. That one's successful (it's a shared Here's my test log for comparison (made on fresh 7.86.0 sources. This one is a static |
|
I've reduced it to I can also create a new issue if wanted. |
Please do, I think we track it better that way |
|
@lazka: Thanks! A separate Issue would be helpful indeed. Do you have any suggestion for a fix? On the surface the cause is |
|
I've filed an issue at #9803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this update autotools builds will compile and link
.rcresourcesto Windows executables. Bringing this feature on par with CMake
and
Makefile.m32builds. And also making it unnecessary to improvisethese steps manually, while monkey patching build files, e.g. [0].
You can customize the resource compiler via the
RCenvvar, and itsoptions via
RCFLAGS.This harmless warning may appear throughout the build, even though the
autotools manual documents [1]
RCas a valid tag:libtool: error: ignoring unknown tag RC[0] https://github.com/curl/curl-for-win/blob/535f19060d4b708f72e75dd849409ce50baa1b84/curl-autotools.sh#L376-L382
[1] https://www.gnu.org/software/libtool/manual/html_node/Tags.html
Closes #9521