Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: add a CI job that runs proselint on all markdown files #9520

Merged
merged 2 commits into from Sep 19, 2022
Merged

gha: add a CI job that runs proselint on all markdown files #9520

merged 2 commits into from Sep 19, 2022

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 16, 2022

No description provided.

@bagder bagder added the CI Continuous Integration label Sep 16, 2022
cmeister2
cmeister2 reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cmeister2 cmeister2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the proselintrc file handling needs a rethink.

.github/workflows/proselint.yml Outdated Show resolved Hide resolved
.github/workflows/proselint.yml Outdated Show resolved Hide resolved
bagder added a commit that referenced this pull request Sep 16, 2022
@bagder
gha: add a CI job that runs proselint on all markdown files
e210e82 
Closes #9520
@bagder
Copy link
Member Author

bagder commented Sep 16, 2022

ok, seems to work now, rebased and squashed into something readable

cmeister2
cmeister2 reviewed Sep 17, 2022
View reviewed changes
Copy link
Contributor

@cmeister2 cmeister2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor quibble with how the proselint json files are mastered, but this is only a recommendation. (I feel like introducing grep and sed into the process is a mistake)

.github/workflows/proselint.yml Outdated Show resolved Hide resolved
.github/workflows/proselint.yml Outdated Show resolved Hide resolved
@cmeister2 cmeister2 mentioned this pull request Sep 17, 2022
Closed
@mback2k mback2k mentioned this pull request Sep 17, 2022
Closed
@bagder
Copy link
Member Author

bagder commented Sep 19, 2022 •
edited

Thanks @mback2k, I've squashed this all into two commits now.

@bagder bagder closed this in 6e0dbe8 Sep 19, 2022
@bagder bagder merged commit fda897f into master Sep 19, 2022
@bagder bagder deleted the bagder/proselint branch September 19, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmeister2 cmeister2 cmeister2 left review comments

@mback2k mback2k Awaiting requested review from mback2k

Assignees
No one assigned
Labels
CI Continuous Integration
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bagder @mback2k @cmeister2