CURLOPT_WILDCARDMATCH.3: Fix backslash escaping under single quotes #9418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lintian (on Debian) has been complaining about this for a while but I didn't bother initially as the groff parser that we use is not affected by this. But I have now noticed that the online manpage is affected by it: https://curl.se/libcurl/c/CURLOPT_WILDCARDMATCH.html (I'm using double quotes for quoting-only down below) The section that should be parsed as "'\'" ends up being parsed as "'´". This is due to roffit not parsing "'\\'" correctly, which is fine as the "correct" way of writing "'\'" is "'\e'" instead. Note that this fix is not enough to fix the online manpage at curl's website, as roffit seems to parse it wrongly either way. My intent is to at least fix the manpage so that roffit can be changed to parse "'\e'" correctly (although I suggest making roffit parse both ways correctly, since that's what groff does). More details at: https://bugs.debian.org/966803 https://salsa.debian.org/lintian/lintian/-/blob/930b18e4b28b7540253f458ef42a884cca7965c3/tags/a/acute-accent-in-manual-page.tag
bagder
added a commit
to bagder/roffit
that referenced
this pull request
Sep 2, 2022
... just to make them less likely to cause problems down the road. Bug: curl/curl#9418 Reported-by: Samuel Henrique
bagder
added a commit
to bagder/roffit
that referenced
this pull request
Sep 2, 2022
Bug: curl/curl#9418 Reported-by: Samuel Henrique
bagder
approved these changes
Sep 2, 2022
|
Thanks! |
bagder
added a commit
to bagder/roffit
that referenced
this pull request
Sep 2, 2022
Bug: curl/curl#9418 Reported-by: Samuel Henrique Closes #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lintian (on Debian) has been complaining about this for a while but
I didn't bother initially as the groff parser that we use is not
affected by this.
But I have now noticed that the online manpage is affected by it:
https://curl.se/libcurl/c/CURLOPT_WILDCARDMATCH.html
(I'm using double quotes for quoting-only down below)
The section that should be parsed as
"'\'"ends up being parsed as"'´".This is due to roffit not parsing
"'\\'"correctly, which is fineas the "correct" way of writing
"'\'"is"'\e'"instead.Note that this fix is not enough to fix the online manpage at
curl's website, as roffit seems to parse it wrongly either way.
My intent is to at least fix the manpage so that roffit can
be changed to parse
"'\e'"correctly (although I suggest makingroffit parse both ways correctly, since that's what groff does).
More details at:
https://bugs.debian.org/966803
https://salsa.debian.org/lintian/lintian/-/blob/930b18e4b28b7540253f458ef42a884cca7965c3/tags/a/acute-accent-in-manual-page.tag