Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS CI jobs fail HTTP/2 tests 1700 + 1701 #9364

Closed
bagder opened this issue Aug 25, 2022 · 4 comments
Closed

macOS CI jobs fail HTTP/2 tests 1700 + 1701 #9364

bagder opened this issue Aug 25, 2022 · 4 comments
Labels
CI Continuous Integration HTTP/2 tests

Comments

@bagder
Copy link
Member

bagder commented Aug 25, 2022

Since a few days back, most (all?) of them fail. example log
@bagder bagder added HTTP/2 tests CI Continuous Integration labels Aug 25, 2022
@bagder bagder mentioned this issue Aug 25, 2022
Closed
@bagder
Copy link
Member Author

bagder commented Aug 25, 2022 •
edited

Curious:

I first ran it successfully with:

libcurl/7.85.0-DEV (SecureTransport) OpenSSL/3.0.5 zlib/1.2.11 brotli/1.0.9 zstd/1.5.2 c-ares/1.18.1 libidn2/2.3.3 nghttp2/1.48.0 librtmp/2.3

Then I ran 'brew upgrade' and now it fails, with:

libcurl/7.85.0-DEV (SecureTransport) OpenSSL/3.0.5 zlib/1.2.11 brotli/1.0.9 zstd/1.5.2 c-ares/1.18.1 libidn2/2.3.3 nghttp2/1.49.0 librtmp/2.3

nghttp2/1.49.0 is the change. Also of course, since the h2 tests uses 'nghttpx' from the nghttp2 package, that was probably updated as well...

@jay
Copy link
Member

jay commented Aug 25, 2022 

2022-08-25T00:48:19.104Z 2176 2177 3ae25fb5 INFO (shrpx_http_downstream_connection.cc:1479) [DCONN:0x010e5acf00] HTTP parser failure: (HPE_CR_EXPECTED) Missing expected CR after header value
2022-08-25T00:48:19.105Z 2176 2177 3ae25fb5 INFO (shrpx_http2_upstream.cc:1288) [DCONN:0x010e5acf00] HTTP parser failure

but it doesn't say what header

@tatsuhiro-t

jay added a commit to jay/curl that referenced this issue Aug 25, 2022
@jay
tests: fix http2 tests to use CRLF headers
b39a451 
Prior to this change test1700 and test1701 did not use CRLF headers
everywhere. Recent changes in nghttp2 (??? ref here) nghttpx proxy
requires curl's HTTP/1.1 test server to use CRLF headers.

Fixes curl#9364
Closes #xxxx
@tatsuhiro-t
Copy link
Contributor

llhttp which nghttpx uses for HTTP/1.x tightens validation on header field separator and it now only accepts CR + LF.
I think the backend returned only LF without CR.

@jay jay mentioned this issue Aug 25, 2022
Closed
@jay
Copy link
Member

jay commented Aug 25, 2022

Ok. #9365 is the attempted fix for those two tests

jay added a commit to jay/curl that referenced this issue Aug 25, 2022
@jay
tests: fix http2 tests to use CRLF headers
221905e 
Prior to this change some tests that rely on nghttpx proxy did not use
CRLF headers everywhere. Recent changes in nghttp2 (??? ref here)
requires curl's HTTP/1.1 test server to use CRLF headers.

Fixes curl#9364
Closes #xxxx
@mback2k mback2k mentioned this issue Aug 25, 2022
Closed
@jay jay closed this as completed in ef12140 Aug 25, 2022
jquepi pushed a commit to jquepi/curl.1.555 that referenced this issue Oct 24, 2022
@jay @jquepi
tests: fix http2 tests to use CRLF headers
dab88c2 
Prior to this change some tests that rely on nghttpx proxy did not use
CRLF headers everywhere. A recent change in nghttp2, which updated its
version of llhttp (HTTP parser), requires curl's HTTP/1.1 test server to
use CRLF headers.

Ref: nghttp2/nghttp2@9d389e8

Fixes curl/curl#9364
Closes curl/curl#9365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration HTTP/2 tests
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: fix http2 tests to use CRLF headers jay/curl
3 participants
@bagder @tatsuhiro-t @jay