Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory debug tracking annotates whether the returns pointer does not … #9306

Closed
wants to merge 1 commit into from
Closed

memory debug tracking annotates whether the returns pointer does not … #9306

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

…alias,

hints where the size required is, for Windows to be better debuggued
via Visual Studio.

MarcelRaad
MarcelRaad reviewed Aug 13, 2022
View reviewed changes
lib/memdebug.h Outdated Show resolved Hide resolved
bagder
bagder approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this seems clever!

@bagder
Copy link
Member

bagder commented Aug 13, 2022

Visual Studio 2015 however, is not happy:

2>wolfssl.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(59) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(98) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(100) : error C2485: 'allocator' : unrecognized extended attribute
2>vtls.c
2>sectransp.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(59) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(98) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(100) : error C2485: 'allocator' : unrecognized extended attribute
2>schannel_verify.c
2>schannel.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(59) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(98) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(100) : error C2485: 'allocator' : unrecognized extended attribute
2>rustls.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute

@devnexen
Copy link
Contributor Author

ah ok 2015 ... ok I m going to remove this specific attr

@MarcelRaad
Copy link
Member

The attributes are required on the implementation too to fix the MSVC build (visible on AppVeyor). Looks good to me apart from that!

@devnexen
memory debug tracking annotates whether the returns pointer does not …
a907092 
…`alias`,

 hints where the size required is, for Windows to be better debuggued
via Visual Studio.
MarcelRaad
MarcelRaad approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The remaining CI failures look unrelated to me.

jquepi pushed a commit to jquepi/curl.1.555 that referenced this pull request Oct 24, 2022
@devnexen @jquepi
memdebug: add annotation attributes
bf28a4f 
memory debug tracking annotates whether the returned pointer does not
`alias`, hints where the size required is, for Windows to be better
debugged via Visual Studio.

Closes curl/curl#9306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devnexen @bagder @MarcelRaad