file: add handling of native AmigaOS paths #9259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AmigaOS 4.x, handle native absolute paths, whilst blocking relative paths. Also allow unix style paths if feature enabled at link time. Inspiration-from: Michael Trebilcock
bagder
reviewed
Aug 6, 2022
| * A leading slash in an AmigaDOS path denotes the parent | ||
| * directory, and hence we block this as it is relative. | ||
| * Absolute paths start with 'volumename:', so we check for | ||
| * this first. Failing that, we treat the path as a real unix |
There was a problem hiding this comment.
Can the volume name be any length? Or maybe it doesn't matter as the open will just fail anyway if tried with a too long name?
There was a problem hiding this comment.
Can the volume name be any length? Or maybe it doesn't matter as the open will just fail anyway if tried with a too long name?
I'm not sure on the length limit (probably 107 characters, at a guess), but it may also differ depending which filesystem is used. Normally, volume names are not that long though, but equally always longer than the drive letter than Windows uses. It shouldn't be a concern and, yes, the file open will fail anyway if the volume name doesn't actually exist.
emilengler
reviewed
Aug 7, 2022
bagder
approved these changes
Aug 8, 2022
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AmigaOS 4.x, handle native absolute paths, whilst blocking relative
paths. Also allow unix style paths if feature enabled at link time.
Inspiration-from: Michael Trebilcock