hyper: enable obs-folded multiline headers #9216
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Jul 27, 2022
|
Yeah, we probably need to edit the 1274 test a little to make it run with hyper. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the option in hyper to allow obs-folded multiline headers, which makes test 1940 pass.
I was hopeful this would fix test 1274, but it seems that test is expecting to receive the bytes before the value is unfolded, and hyper unfolds as part of the parsing step. The header value is still received, just without the newlines. So a curl user depending on a folded header could still work, if they don't blindly unfold.
We can either edit that test directly to allow the expected output to be unfolded if hyper is enabled, or disable the test directly.