CMake: link curl to its dependencies with PRIVATE #9125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Jul 10, 2022
The current PUBLIC visibility causes issues for downstream users. Cf OSGeo/PROJ#3172 (comment)
rouault
force-pushed
the
cmake_private_link_libraries
branch
from
a98f552
to
dd7460c
Compare
rouault
changed the title
|
Is this the equivalent of the autoconf option --enable-symbol-hiding or is it
something else?
|
No. It is not on this level. It is more like |
jzakrzewski
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Seems correct.
Before the change we actually got unnecessary overlinking when using with FetchContent. Since libcurl does not use any symbols from 3-party libraries in its interface this is the way to go.
Note this may break some projects that assumed that libcurl will pull those dependencies in, but they should have never assume it in the first place and link, what they use.
|
Thanks! |
This was referenced Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PUBLIC visibility causes issues for downstream users.
Cf OSGeo/PROJ#3172 (comment)