Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: remove APPEND in export(TARGETS) #9124

Closed

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jul 8, 2022

When running cmake several times, new content was appended to already
existing generated files, which is not appropriate

When running cmake several times, new content was appended to already
existing generated files, which is not appropriate
@bagder bagder added the cmake label Jul 9, 2022
@bagder bagder requested a review from jzakrzewski July 9, 2022 21:39
Copy link
Contributor

@jzakrzewski jzakrzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
There is a single target in each file anyway, so appending did not make sense from the beginning I guess.

@bagder bagder closed this in 7ac3607 Jul 12, 2022
@bagder
Copy link
Member

bagder commented Jul 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants