tool_operate.c: fix several problems about the usage of curl_easy_init() #9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the one hand, curl_easy_init() returns NULL if some errors happen. So it is better to check the return of it to propagate the proper status. Without the check, if curl_easy_init() fails, transfer_per_config() will return CURLE_UNKNOWN_OPTION since curl_easy_getinfo() returns that status when the first argument is NULL. On the other hand, we should call curl_easy_cleanup() to prevent potential memory leaks on other error handling paths.
|
There may some places in the code where we call curl_easy_getinfo without first checking the curl_easy_init return. You could change curl_easy_getinfo to return CURLE_BAD_FUNCTION_ARGUMENT for NULL handle. Regardless though, I'm not opposed to cleaning them up. |
…nt and remove the check for curl_easy_init() before curl_easy_getinfo()
|
Thank you for your suggestion. I removed the check for curl_easy_init() before curl_easy_getinfo(), and made Curl_getinfo() return CURLE_BAD_FUNCTION_ARGUMENT for handling NULL of the first argument. |
bagder
approved these changes
Jul 10, 2022
|
Thanks! |
bagder
pushed a commit
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the one hand, curl_easy_init() returns NULL if some errors happen.
So it is better to check the return of it to propagate the proper status.
Without the check, if curl_easy_init() fails, transfer_per_config() will
return CURLE_UNKNOWN_OPTION since curl_easy_getinfo() returns that status
when the first argument is NULL.
On the other hand, we should call curl_easy_cleanup() to prevent potential
memory leaks on other error handling paths.