cmake: support ngtcp2 boringssl backend #9065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the ngtcp2 find module to detect the boringssl backend. Determine if the underlying OpenSSL implementation is BoringSSL and if so use that as the ngtcp2 backend.
|
Makes it so #8789 will build in CMake. I'm guessing maybe the autotools one already works with the ngtcp2 + BoringSSL backend. If not then something like this would also need to be done. |
|
Hey @bagder anything in particular you want addressed here? I was able to build a version of curl with HTTP/3 support and run it in on the curl network backend in WebKit. |
|
I was hoping someone who knows cmake would chime in... |
|
I don't have time to build & test, but otherwise it looks clean to me. |
|
Thanks @jzakrzewski that's good enough for me! |
|
Thanks! |
|
Thanks @jzakrzewski and @bagder ! |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ngtcp2 find module to detect the boringssl backend. Determine if the underlying OpenSSL implementation is BoringSSL and if so use that as the ngtcp2 backend.