test3026: add support for Windows using native Win32 threads #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mback2k
force-pushed
the
test-3026-windows
branch
2 times, most recently
from
c750e3f
to
d2510b4
Compare
mback2k
force-pushed
the
test-3026-windows
branch
from
d2510b4
to
959c490
Compare
mback2k
changed the title
vszakats
reviewed
Jun 16, 2022
vszakats
approved these changes
Jun 16, 2022
|
It seems like the threadsafe init is broken on 32-Bit Windows. |
All the CI failures I see are errno 8 (ERROR_NOT_ENOUGH_MEMORY). Creating 1000 test threads is probably too many. Which CI are you referring to? You could try changing the stack size? Also I think on error it should say GetLastError instead of errno since it's actually an error code from the former. |
jay
reviewed
Jun 17, 2022
If that is a problem, we can probably consider it tested with 100 too... |
|
Yeah, I will try to reduce the number of threads in case a 32-bit build is done. |
jay
added a commit
that referenced
this pull request
Jun 21, 2022
Follow-up to recent commits which added thread-safety support. Bug: #9012 (comment) Reported-by: Marc Hörsken Closes #xxxx
jay
added a commit
that referenced
this pull request
Jun 21, 2022
Follow-up to recent commits which added thread-safety support. Bug: #9012 (comment) Reported-by: Marc Hörsken Closes #9030
mback2k
force-pushed
the
test-3026-windows
branch
from
959c490
to
53fdb2e
Compare
bagder
reviewed
Jul 19, 2022
mback2k
force-pushed
the
test-3026-windows
branch
from
53fdb2e
to
40a74f3
Compare
vszakats
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure the result is initialized to an invalid value (
CURL_LAST) before the corresponding thread is launched.Follow up to #8996