New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop misuse of CMake's -H
flag
#9008
Comments
My cmake manpage shows |
that seems to actually be true when |
The option that should be used instead of We can either remove Removing
Line 42 in 4572489
Also, when
|
This is an undocumented option, but behaves similarly to the `-S <path>` introduced in cmake 3.10. Since curl's current CMakeLists.txt file supports cmake 3.2 or newer, we are replacing `-Hsdir -Bbdir` with the more portable `-Bbdir sdir` instead of `-Sbdir -Bbdir`. Fixes curl#9008
`-Hdir` is an undocumented option that behaves similarly to the `-S <path>` option introduced in cmake 3.10. Since curl's current CMakeLists.txt file supports cmake 3.2 or newer, we are replacing `-Hsdir -Bbdir` with the more portable `-Bbdir sdir` instead of `-Sbdir -Bbdir`. Fixes curl#9008
The origin of this functionality is Kitware/CMake@72bc795#diff-9451a015783be6eaba0a5a470186420c922d536fc465b80a4cdba55dec61d749R106, however as you noted this was never documented nor really supported.
Before that, the current working directory was the binary directory and the passed path argument was the source directory.
This is not a change that is concerned with the project code at all. This is purely about how |
I am aware that is not a problem since these are
You are right, |
This is an undocumented option similar to the `-Spath` option intruced in cmake 3.13. Replace all instances of `-Hpath' with `-Spath'. Fixes curl#9008
This is an undocumented option similar to the `-Spath' option intruced in cmake 3.13. Replace all instances of `-Hpath' with `-Spath' in macos workflow. Replace `-H. -Bpath' with `mkdir path; cd ./path; cmake ..' in zuul scripts since it runs an older version of cmake. Fixes curl#9008
This is an undocumented option similar to the `-Spath' option introduced in cmake 3.13. Replace all instances of `-Hpath' with `-Spath' in macos workflow. Replace `-H. -Bpath' with `mkdir path; cd ./path; cmake ..' in zuul scripts since it runs an older version of cmake. Fixes curl#9008
Reference: #8982 (comment)
For justification, see this commit microsoft/vscode-cmake-tools@2c181de and the issue it closes.
A very quick search reveals 4 usages. They should be replaced according to what version of CMake is invoked at usage site. Details for how to proceed are also contained in the above referenced commit.
The text was updated successfully, but these errors were encountered: