Ngtcp2 fix sendmsg build issue #8981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsuhiro-t
force-pushed
the
ngtcp2-fix-sendmsg-build-issue
branch
from
3362026
to
9bbaa28
Compare
vszakats
approved these changes
Jun 8, 2022
emilengler
reviewed
Jun 10, 2022
| @@ -944,7 +944,7 @@ CURLcode Curl_quic_connect(struct Curl_easy *data, | |||
|
|
|||
| ngtcp2_connection_close_error_default(&qs->last_error); | |||
|
|
|||
| #if defined(__linux__) && defined(UDP_SEGMENT) | |||
| #if defined(__linux__) && defined(UDP_SEGMENT) & defined(HAVE_SENDMSG) | |||
There was a problem hiding this comment.
Should this really be only one ampersand?
| struct iovec msg_iov = {(void *)pkt, pktlen}; | ||
| struct msghdr msg = {0}; | ||
| uint8_t msg_ctrl[CMSG_SPACE(sizeof(uint16_t))] = {0}; | ||
| uint8_t msg_ctrl[32]; |
There was a problem hiding this comment.
Is the 32 a random choice and if not, would you mind making it a constant?
|
|
||
| *psent = 0; | ||
|
|
||
| while((sent = send(sockfd, (const char *)pkt, pktlen, 0)) == -1 && |
There was a problem hiding this comment.
Is the cast necessary? Usually passing any pointer to a void * works just fine.
There was a problem hiding this comment.
Sadly it's necessary, because on Windows, it is a const char *.
See also: #8978 (comment)
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 10, 2022
Ref: curl#8981 (comment) Reported-By: Emil Engler Closes #xxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 10, 2022
Ref: curl#8981 (comment) Ref: 927ede7 Reported-By: Emil Engler Closes #xxxx
vszakats
added a commit
that referenced
this pull request
Jun 10, 2022
Ref: 927ede7 Bug: #8981 (comment) Reported-by: Emil Engler Closes #8987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8978