Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable --no-remote-name #8931

Closed
wants to merge 1 commit into from
Closed

Re-enable --no-remote-name #8931

wants to merge 1 commit into from

Conversation

verhovsky
Copy link
Contributor

@verhovsky verhovsky commented May 28, 2022 •
edited

The docs for --remote-name-all say

you must use "-o -" or --no-remote-name.

but with curl 7.83 on macOS I get

$ curl --no-remote-name
curl: option --no-remote-name: used '--no-' for option that isn't a boolean
curl: try 'curl --help' or 'curl --manual' for more information

So either the option should be put back (it was incorrectly marked as ARG_NONE instead of ARG_BOOL) or the docs should be updated.

@verhovsky verhovsky changed the title Undocument --no-remote-name Undocument deleted --no-remote-name option May 28, 2022
@verhovsky verhovsky changed the title Undocument deleted --no-remote-name option Re-enable --no-remote-name May 28, 2022
@bagder
Copy link
Member

bagder commented May 28, 2022

I would be great to also write up a test case that uses this feature so that we can make sure we don't break it again in the future...

@bagder
Copy link
Member

bagder commented May 31, 2022

Ok, I have written a test locally that verifies. I'll make a separate PR after I've merged this.

@bagder bagder closed this in 83ee5c4 May 31, 2022
@bagder
Copy link
Member

bagder commented May 31, 2022

Thanks!

bagder added a commit that referenced this pull request May 31, 2022
@bagder
test681: verify --no-remote-name
6606315 
Follow-up to 83ee5c4 (from #8931)
@bagder bagder mentioned this pull request May 31, 2022
Closed
bagder added a commit that referenced this pull request May 31, 2022
@bagder
test681: verify --no-remote-name
ef94c97 
Follow-up to 83ee5c4 (from #8931)

Closes #8942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmdline tool
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@verhovsky @bagder