headers api: remove EXPERIMENTAL tag #8900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A complete lack of feedback, but I feel fairly confident this is good enough. |
bagder
force-pushed
the
bagder/headers-api-unexperiment
branch
from
15b4c0f
to
eb1cb89
Compare
|
FWIW I have played with it a bit - at least the 'happy paths' seem robust enough |
bagder
added a commit
that referenced
this pull request
May 25, 2022
bagder
force-pushed
the
bagder/headers-api-unexperiment
branch
from
eb1cb89
to
4a7359b
Compare
bagder
added a commit
that referenced
this pull request
May 25, 2022
bagder
force-pushed
the
bagder/headers-api-unexperiment
branch
from
4a7359b
to
78e04d5
Compare
|
Somewhat related note: test 1940 is consistently broken on the Cirrus CI Windows builds due to invalid line endings. Maybe something is written with the wrong mode there? Generally speaking: IMHO Windows CI stability is now at a point there it makes sense to always review failures instead of ignoring them without looking at all and thinking the flakiness is the cause. 😉 |
|
I've seen it, but the test runs fine on appveyor builds. The line endings should be fine as the section is marked as text. I don't know why it happens. |
bagder
force-pushed
the
bagder/headers-api-unexperiment
branch
from
78e04d5
to
7633ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.