Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax UndefinedBehavior sanitizer #8797

Closed
wants to merge 1 commit into from
Closed

Relax UndefinedBehavior sanitizer #8797

wants to merge 1 commit into from

Conversation

sergio-nsk
Copy link
Contributor

while(i--) causes runtime error: unsigned integer overflow: 0 - 1 cannot be
represented in type 'size_t' (aka 'unsigned long')

@sergio-nsk
Relax UndefinedBehavior sanitizer
e13587b 
`while(i--)` causes runtime error: unsigned integer overflow: 0 - 1 cannot be
represented in type 'size_t' (aka 'unsigned long')
sergio-nsk
sergio-nsk commented May 5, 2022
View reviewed changes
Copy link
Contributor Author

@sergio-nsk sergio-nsk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

bagder
bagder approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A benign use, but I can't see any harm in this change if it silences a warning here.

@bagder
Copy link
Member

bagder commented May 5, 2022

Thanks!

@bagder bagder closed this in b5b8685 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergio-nsk @bagder