Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

building with --disable-http-auth fails with "undefined reference to `Curl_allow_auth_to_host'" #8772

Closed
michaelolbrich opened this issue Apr 29, 2022 · 1 comment
Closed

building with --disable-http-auth fails with "undefined reference to `Curl_allow_auth_to_host'" #8772

michaelolbrich opened this issue Apr 29, 2022 · 1 comment
Assignees
@bagder
Labels
authentication build HTTP

Comments

@michaelolbrich
Copy link

I did this

configure with --disable-http-auth

I expected the following

building curl shoud succeed

curl/libcurl version

7.83.0

The problem is here:

curl/lib/http.c

Line 1920 in 685170b

!Curl_allow_auth_to_host(data))

This call to Curl_allow_auth_to_host() is not protected by a CURL_DISABLE_HTTP_AUTH check but the implementation of the function is.
@bagder bagder self-assigned this Apr 29, 2022
bagder added a commit that referenced this issue Apr 29, 2022
@bagder
http: move Curl_allow_auth_to_host()
fd2fa61 
It was mistakenly put within the CURL_DISABLE_HTTP_AUTH #ifdef

Reported-by: Michael Olbrich
Fixes #8772
@bagder bagder mentioned this issue Apr 29, 2022
Closed
@bagder
Copy link
Member

bagder commented Apr 29, 2022

Fixed in commit d7b970e

@bagder bagder closed this as completed Apr 29, 2022
kadler pushed a commit to kadler/curl that referenced this issue Apr 29, 2022
@bagder
http: move Curl_allow_auth_to_host()
d7b970e 
It was mistakenly put within the CURL_DISABLE_HTTP_AUTH #ifdef

Reported-by: Michael Olbrich
Fixes curl#8772
Closes curl#8775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
authentication build HTTP
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http: move Curl_allow_auth_to_host() curl/curl
2 participants
@bagder @michaelolbrich