msh3: print boolean value as text representation #8763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print the boolean value as its string representation instead of with %hhu which isn't a format we typically use.
nibanks
reviewed
Apr 27, 2022
So embarrassingly enough I was about to say that So, let's turn to science to see what to do: $ git grep "?\"[^:]\+:\"" | wc -l
60
$ git grep "? \"[^:]\+ : \"" | wc -l
65It's pretty close but adding spaces clearly wins, so I will go do that before merging. That got me curious though, what other permutations turn up? $ git grep "? \"[^:]\+[^ ]: \"" | wc -l
35
$ git grep "? \"[^:]\+ :\"" | wc -l
1Maybe we should have a rule about this after all? =) |
Hehe, I was also convinced checksrc already checked for this, but apparently not... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the boolean value as its string representation instead of with
%hhuwhich isn't a format we typically use. I don't have strong feelings wrt this in case others disagree, but%hhustruck me as odd when skimming the code.