New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: remove exclamation marks #8713
Conversation
... from infof() and failf() calls. Make them less attention seeking. Closes #8713
2692b01
to
0c820f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this one in lib/vquic/ngtcp2.c
?:
H3BUGF(infof(data, "!!!!!!!!! cb_h3_readfunction sets EOF"));
It is a debug output, but unless the exclamation marks means something I think it can be improved.
Indeed. I'll remove them from there. |
This change broke pycurl's test-suite:
|
I'm sorry, but who tests human-readable error messages from the 3-party code? |
... from infof() and failf() calls. Make them less attention seeking.