http2: fix handling of client-initiated "done" #8664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it could otherwise stall all streams on the connection Reported-by: Evangelos Foutras Fixes #8626
For the "simulated 304" case the done-call isn't considered "premature" but since the server didn't close the stream it needs to be reset to stop delivering data.
bagder
added a commit
that referenced
this pull request
Apr 1, 2022
bagder
added a commit
that referenced
this pull request
Apr 1, 2022
For the "simulated 304" case the done-call isn't considered "premature" but since the server didn't close the stream it needs to be reset to stop delivering data. Closes #8664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When libcurl decides to "simulate" a 304 response due to time condition, there were several small mistakes made. One of which in particular caused #8626