Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some Spellcheck/fixes discoverd by lift #8616

Closed
wants to merge 25 commits into from
Closed

some Spellcheck/fixes discoverd by lift #8616

wants to merge 25 commits into from

Conversation

pheiduck
Copy link
Contributor

No description provided.

@pheiduck pheiduck changed the title Spellcheck/fixes in lib/firefox-db2pem.sh discoverd by lift some Spellcheck/fixes discoverd by lift Mar 20, 2022
@pheiduck
initscript.sh: Double quote to prevent globbing and word splitting.
3064ca3
@pheiduck
initscript.sh: This does not export '1'. Remove $/${} for that, or us…
c6bdb2c 
…e ${var?} to quiet.
@pheiduck
initscript.sh: Use $(...) notation instead of legacy backticks
31ef7dd
@pheiduck
make-include.sh: Use $(...) notation instead of legacy backticks
968ec72
@pheiduck
make-include.sh: Use 'cd ... || exit' or 'cd ... || return' in case c…
c7a12aa 
…d fails.
@pheiduck
make-lib.sh: Double quote to prevent globbing and word splitting.
37de45a
@pheiduck
make-lib.sh: Use $(...) notation instead of legacy backticks
7d34503
@pheiduck
make-lib.sh: Use 'cd ... || exit' or 'cd ... || return' in case cd fa…
fca7000 
…ils.
@pheiduck
make-tests.sh: Use $(...) notation instead of legacy backticks and Us…
28f8aae 
…e 'cd ... || exit' or 'cd ... || return' in case cd fails.
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 20, 2022
View reviewed changes
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 20, 2022
View reviewed changes
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 20, 2022
View reviewed changes
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 20, 2022
View reviewed changes
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
@pheiduck pheiduck marked this pull request as draft March 21, 2022 05:59
@pheiduck pheiduck marked this pull request as ready for review March 21, 2022 08:42
@monnerat
Copy link
Contributor

I totally disagree with the OS400 scripts changes: we are dealing with i5 qshell scripts and not bash scripts: the $(...) syntax is not recognized.
In addition, the setenv() procedure semantics is altered and the result is not what we expect.
Better leave off lift for IBM i5 !

@pheiduck pheiduck closed this Mar 21, 2022
@pheiduck pheiduck deleted the spellcheck/fixes branch March 21, 2022 11:46
@pheiduck pheiduck mentioned this pull request Mar 21, 2022
Closed
bagder pushed a commit that referenced this pull request Mar 22, 2022
@pheiduck @bagder
firefox-db2pem.sh: make the shell script safer
98b40c6 
Reported by lift

Closes #8616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pheiduck @monnerat