Skip to content

fixup dead links discovered by Markdown links Check #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

fixup dead links discovered by Markdown links Check #8597

wants to merge 8 commits into from

Conversation

pheiduck
Copy link
Contributor

Error noticeable in Markdown links CI:
ERROR: 1 dead links found! [✖] https://msdn.microsoft.com/en-us/library/f2ccy3wt.aspx → Status: 403

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
ERROR: 1 dead links found!   [✖] https://msdn.microsoft.com/en-us/library/f2ccy3wt.aspx → Status: 403
@pheiduck
Copy link
Contributor Author

pheiduck commented Mar 15, 2022

https://curl.zuul.vexxhost.dev/builds Zuul Builds are as well not reachable
The SSL - Certificate needs to be renewed for this url:
Expired: Tuesday, 8. March 2022 at 20:28:41 Central European Standard Time

@pheiduck pheiduck changed the title fixup dead link: https://msdn.microsoft.com/en-us/library/f2ccy3wt.aspx fixup dead links Mar 15, 2022
@pheiduck pheiduck changed the title fixup dead links fixup dead links discovered by Markdown links CI Mar 15, 2022
pheiduck and others added 4 commits March 15, 2022 19:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Unverified

No user is associated with the committer email.
Signed-off-by: pheiduck <pheiduck@github.com>
@pheiduck
Copy link
Contributor Author

pheiduck commented Mar 15, 2022

I added a mlc_config.json file to ignore https://curl.zuul.vexxhost.dev/ as workaround.

@pheiduck pheiduck changed the title fixup dead links discovered by Markdown links CI fixup dead links discovered by Markdown links Check Mar 15, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…e Builds
@pheiduck pheiduck requested a review from bagder March 17, 2022 13:43

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bagder
Copy link
Member

bagder commented Mar 18, 2022

Thanks!

@bagder bagder closed this in c652621 Mar 18, 2022
bagder pushed a commit that referenced this pull request Mar 18, 2022

Partially verified

This commit is signed with the committer’s verified signature.
bagder’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
This is the config file for the CI markdown link checker and lets us
filter URLs that are known to cause problems. Like
https://curl.zuul.vexxhost.dev/ for now.

Closes #8597
@pheiduck pheiduck deleted the fixup/dead-url branch March 18, 2022 08:31
Copy link
Member

@vszakats vszakats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants