Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Win32] crash in unit1610.exe #8538

Closed
gvanem opened this issue Mar 4, 2022 · 3 comments
Closed

[Win32] crash in unit1610.exe #8538

gvanem opened this issue Mar 4, 2022 · 3 comments
Labels
crash tests Windows Windows-specific

Comments

@gvanem
Copy link
Contributor

gvanem commented Mar 4, 2022

Compiling and running unit1610.exe www.curl.se, caused a crash inside OpenSSL;
calling a func-ptr c_set_error_mark which is NULL:

0x0
unit1610!ERR_set_mark(void)+0x8
unit1610!CONF_modules_load_file_ex(struct ossl_lib_ctx_st * libctx = 0x00000000, char * filename = 0x00000000 "", char * appname = 0x00000000 "", unsigned long flags = 0x32)+0xb6
unit1610!CONF_modules_load_file(char * filename = 0x00000000 "", char * appname = 0x00000000 "", unsigned long flags = 0x32)+0x13
unit1610!ossl_config_int(struct ossl_init_settings_st * settings = 0x00000000)+0x32
unit1610!ossl_init_config_ossl_(void)+0x7
unit1610!CRYPTO_THREAD_run_once(long * once = 0x00ea90d8, <function> * init = 0x009fbc40)+0x36
unit1610!OPENSSL_init_crypto(unsigned int64 opts = 0x40, struct ossl_init_settings_st * settings = 0x00000000)+0x314
unit1610!ossl_engine_table_select(struct st_engine_table ** table = 0x00ea911c, int nid = 0x2a0, char * f = 0x00d61d60 "crypto/engine/tb_digest.c", int l = 0x45)+0x17
unit1610!ENGINE_get_digest_engine(int nid = 0x2a0)+0x15
unit1610!evp_md_init_internal(struct evp_md_ctx_st * ctx = 0x047a0738, struct evp_md_st * type = 0x00d427d8, struct ossl_param_st * params = 0x00000000, struct engine_st * impl = 0x00000000)+0x157
unit1610!EVP_DigestInit_ex(struct evp_md_ctx_st * ctx = 0x047a0738, struct evp_md_st * type = 0x00d427d8, struct engine_st * impl = 0x00000000)+0x13
unit1610!Curl_sha256it(unsigned char * output = 0x0072f8f0 "???", unsigned char * input = 0x0072f8dc "1", unsigned int length = 1)+0x1f
unit1610!test(char * arg = 0x0c7b19d5 "www.curl.se")+0x5a
...

Also some context is not set correctly and the filename == NULL. But AFAICS, OpenSSL would then use some
default openssl.conf file (?)

So the question is whether this is a mis-use of OpenSSL in the unit-tests, a flaw in how my OpenSSL is built
or simply a bug in OpenSSL itself.

But if I patch it like this:

--- a/unit/unit1610.c 2022-03-04 06:19:29
+++ b/unit/unit1610.c 2022-03-04 11:38:31
@@ -25,6 +25,7 @@

 static CURLcode unit_setup(void)
 {
+  OPENSSL_init_ssl(0x80L, NULL); // OPENSSL_INIT_NO_LOAD_CONFIG
   return CURLE_OK;
 }

there is no crash
@bagder bagder added crash tests Windows Windows-specific labels Mar 4, 2022
jay added a commit to jay/curl that referenced this issue Mar 4, 2022
@jay
unit1610: init SSL library before calling SHA256 functions
2a37c26 
The SSL library must be initialized (via global initialization) because
libcurl's SHA256 functions may call SHA256 functions in the SSL library.

Reported-by: Gisle Vanem

Fixes curl#8538
Closes #xxxx
@jay jay mentioned this issue Mar 4, 2022
Closed
@jay
Copy link
Member

jay commented Mar 4, 2022

please try #8540

jay added a commit to jay/curl that referenced this issue Mar 4, 2022
@jay
unit1610: init SSL library before calling SHA256 functions
5d2e169 
The SSL library must be initialized (via global initialization) because
libcurl's SHA256 functions may call SHA256 functions in the SSL library.

Reported-by: Gisle Vanem

Fixes curl#8538
Closes #xxxx
@gvanem
Copy link
Contributor Author

gvanem commented Mar 5, 2022

Your fix works fine.

@jay jay closed this as completed in 522e46c Mar 5, 2022
@jay
Copy link
Member

jay commented Mar 5, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash tests Windows Windows-specific
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unit1610: init SSL library before calling SHA256 functions jay/curl
3 participants
@bagder @gvanem @jay