Fixed BearSSL bug: EXC_BAD_ACCESS on incomplete CA cert #8476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from: #8106
When having a incomplete CA cert (for example missing a newline at the end) in the function
load_cafile
the code aftercase BR_PEM_END_OBJ:
will not be executed. This will result in an extrata
(ca.anchors
) that does not have its data set. Becauseta->dn.len
is not set (thus a random value) this will result in EXC_BAD_ACCESS in BearSSL because it expects correct values. The fix is to only add the newta
aftercase BR_PEM_END_OBJ:
.