Fix build errors when using GSKit #8454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f0bb86 replaced sterror with Curl_strerror, but the strerror buffer shadows the set_buffer "buffer" parameter. To keep consistency with the other functions that use Curl_strerror, rename the parameter. In addition, strerror.h is needed for the definition of STRERROR_LEN.
In c30bf22, Curl_ssl_getsock was factored out in to a member of struct Curl_ssl but the gskit initialization was not updated to reflect this new member.
As mentioned in 32766cb, gskit was the last user of Curl_select which is now gone. Convert to using Curl_poll to allow build to work on IBM i.
|
@NattyNarwhal can you look at these changes compare with the fixes you made? |
|
I didn't have any changes other than what I made PRs for last; haven't looked at ILE curl in a while. |
|
Ah, ok. I misunderstood and thought you meant you had changes outstanding. |
|
Thanks! |
bagder
pushed a commit
that referenced
this pull request
Feb 16, 2022
In c30bf22, Curl_ssl_getsock was factored out in to a member of struct Curl_ssl but the gskit initialization was not updated to reflect this new member. Closes #8454
bagder
pushed a commit
that referenced
this pull request
Feb 16, 2022
As mentioned in 32766cb, gskit was the last user of Curl_select which is now gone. Convert to using Curl_poll to allow build to work on IBM i. Closes #8454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes in master have caused the GSKit build to break, which is used by the IBM i ILE (OS400) build.