mime: use a define instead of the magic number 24 #8441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIME_BOUNDARY_DASHES is now the number of leading dashes in the generated boundary string.
Oh yes, and I think it has to be merged with pending PR #8423 as it targets the same code region. Do you want me to do it? |
|
I can merge this one first as it is so simple, then you can just rebase your PR on master. |
|
Oh, I merged the another one already so I will fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIME_BOUNDARY_DASHES is now the number of leading dashes in the
generated boundary string.
@monnerat approve?