Support HTTP/3 stream reset detection in quiche backend #8437
Labels
HTTP/3
h3 or quic related
Comments
bagder
added a commit
that referenced
this issue
Feb 11, 2022
A stream reset now causes a CURLE_PARTIAL_FILE error. I'm not convinced this is the right action nor the right error code. Reported-by: Lucas Pardue Fixes #8437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did this
Looked at the HTTP/3 polling code in quiche backend -
curl/lib/vquic/quiche.c
Line 619 in 96f85a0
I expected the following
A case statement for
QUICHE_H3_EVENT_RESEThttps://github.com/cloudflare/quiche/blob/6437b3c2db0dd3c1d6c76cb71d784c874b185d01/quiche/include/quiche.h#L670curl/libcurl version
curl @ 96f85a0
operating system
n/a
Rational
The server can reset response streams at any time, These are similar to Finished events except that body data doesn't have to be read to completion before Reset is fired. Not checking for Resets could mean that the client mistakenly sees the stream alive, while the server sees it as terminated.
Furthermore, if curl implements support for cancelling the Request stream (see https://github.com/cloudflare/quiche/blob/6437b3c2db0dd3c1d6c76cb71d784c874b185d01/quiche/include/quiche.h#L329) that will cause a STOP_SENDING to be sent, which will trigger the server to Reset it's side of the stream.
The text was updated successfully, but these errors were encountered: