Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPF: drop support #8378

Closed
wants to merge 2 commits into from
Closed

TPF: drop support #8378

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 3, 2022

There has been no TPF related changes done since September 2010 (commit
7e1a45e) and since this is a platform that is relatively different
than many others (== needs attention), I draw the conclusion that this
build is broken since a long time.

@bagder bagder added the tidy-up label Feb 3, 2022
@monnerat
Copy link
Contributor

monnerat commented Feb 3, 2022

If you do that, this is also an open door for all the CURL_DOES_CONVERSIONS stuff removal, as it seems this is the only platform using it.
Just my 2 cents!

@bagder
Copy link
Member Author

bagder commented Feb 3, 2022

Oh wow, thanks for highlighting this fact. I think that's actually also another strong reason to suspect that the TPF build doesn't work anymore as the conversion stuff is fairly complicated and easy to mess up.

Also, a fairly big gain to be able to rip that out as this define complicates the logic in many places.

@monnerat
Copy link
Contributor

monnerat commented Feb 3, 2022

Big slashing, isn't it ! :-)

@bagder
Copy link
Member Author

bagder commented Feb 3, 2022

Yes, that is a significant chunk. There might even be some more to fix after this when some flows have been simplified.

lib/setopt.c Outdated Show resolved Hide resolved
There has been no TPF related changes done since September 2010 (commit
7e1a45e) and since this is a platform that is relatively different
than many others (== needs attention), I draw the conclusion that this
build is broken since a long time.

Closes #8378
TPF was the only user and support for that was dropped.

Closes #8378
@bagder bagder closed this in da15443 Feb 4, 2022
bagder added a commit that referenced this pull request Feb 4, 2022
TPF was the only user and support for that was dropped.

Closes #8378
@bagder bagder deleted the bagder/rm-tpf branch February 4, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants