Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: set CURL_LIBRARY_PATH for nghttp2 #8340

Closed
wants to merge 1 commit into from
Closed

configure: set CURL_LIBRARY_PATH for nghttp2 #8340

wants to merge 1 commit into from

Conversation

bwncp
Copy link
Contributor

@bwncp bwncp commented Jan 27, 2022

To execute the test program, we might need the library path so that the lib is found at runtime.

bagder
bagder requested changes Jan 27, 2022
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the variable seems like the right change indeed, but I think it should be done slightly further down, in the code block where USE_NGHTTP2 is set. Because otherwise you might have it set before it is confirmed to be the right version.

@bwncp
Copy link
Contributor Author

bwncp commented Jan 28, 2022

Setting the variable seems like the right change indeed, but I think it should be done slightly further down, in the code block where USE_NGHTTP2 is set. Because otherwise you might have it set before it is confirmed to be the right version.

Thanks for your feedback.

Fixed now.

@bwncp bwncp requested a review from bagder January 28, 2022 11:08
@bwncp bwncp marked this pull request as draft January 28, 2022 11:08
@bwncp
configure: set CURL_LIBRARY_PATH for nghttp2
3271796 
To execute the test program, we might need the library path so that the lib
is found at runtime.
@bwncp bwncp marked this pull request as ready for review January 28, 2022 11:12
@bagder
Copy link
Member

bagder commented Jan 28, 2022

Thanks!

@bagder bagder closed this in ac55564 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwncp @bagder