Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--tlsv1.3 does not seem to work as expected #8309

Closed
icing opened this issue Jan 20, 2022 · 3 comments
Closed

--tlsv1.3 does not seem to work as expected #8309

icing opened this issue Jan 20, 2022 · 3 comments
Labels
TLS

Comments

@icing
Copy link
Contributor

icing commented Jan 20, 2022

I did this

In my Apache httpd test suite for mod_tls(rustls) I run

> curl --tlsv1.3 url

and a TLSv1.2 connection is negotiated.

I expected the following

I expected either a connection with TLSv1.3 or a failure if not supported/negotiated.

Using a locally build curl 7.81.0 with OpenSSL 3.0.1 works as expected. Maybe this is some half-baked libressl 1.3 support?

curl/libcurl version

> curl --version
curl 7.77.0 (x86_64-apple-darwin21.0) libcurl/7.77.0 (SecureTransport) LibreSSL/2.8.3 zlib/1.2.11 nghttp2/1.42.0
Release-Date: 2021-05-26
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS GSS-API HSTS HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL UnixSockets
[curl -V output]

operating system

macOS Monterey 12.1
@bagder bagder added the TLS label Jan 20, 2022
@bagder
Copy link
Member

bagder commented Jan 20, 2022

Apparently TLS 1.3 is supported by default since libressl 3.1.1. The preprocessor symbols seem to exist before that.

@bagder
Copy link
Member

bagder commented Jan 20, 2022

Ah no, I misdiagnosed. PR pending.

bagder added a commit that referenced this issue Jan 20, 2022
@bagder
openssl: return error if TLS 1.3 is requested when not supported
befc011 
Previously curl would just silently ignore it if the necessary defines
are not present at build-time.

Reported-by: Stefan Eissing
Fixes #8309
@bagder bagder mentioned this issue Jan 20, 2022
Closed
@bagder bagder closed this as completed in d03cb7c Jan 21, 2022
@icing
Copy link
Contributor Author

icing commented Jan 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

openssl: return error if TLS 1.3 is requested when not supported curl/curl
2 participants
@icing @bagder