New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile error 7.81.0 with OpenSSL 1.0.2u (VC14, Winbuild, multissl) #8240
Comments
Reverting that will instead break the build when ngtcp2 is used. |
... by instead using the struct version of the typedef'ed pointer. To fix build errors when both Schannel and OpenSSL are enabled. Fixes #8240 Reported-by: Jan Ehrhardt
Looking at c148f0f (briefly), would a solution with |
It wouldn't solve it, since you could build curl with quic support and still support OpenSSL + Schannel for TLS. |
I'm trying a different take as you can see in #8246 |
I will test it. BTW: it did not error when building with OpenSSL 1.1.1m, even if I stiil use VC14 for a Windows version of PHP 7.1 with an upgraded OpenSSl. |
Is ENABLE_QUIC missing in the winbuild way of building curl or just undocumented in https://github.com/curl/curl/blob/master/winbuild/README.md ? |
Both I guess. QUIC/HTTP/3 is still an experimental feature and is not enabled by default anywhere. |
Tested #8246 with VC14, x86. Building fine with either OpenSSL 1.0.2u or OpenSSL 1.1.1m. Will test further with VC9, VC11, VC14, VC15, VS16, x86 and x64. Looking OK. |
Your affort (pun intended) was successful. I have rebuilt 12 different curl versions without compile errors. Of course, I cannot test QUIC support, because it is not supported in winbuild. |
The ngtcp2 CI builds turned green as well so let's merge this. |
It did not error with OpenSSL 1.1.1m using winbuild, but it did error while using CMake. This was also solved by #8246 See https://www.apachelounge.com/viewtopic.php?p=40862#40862 |
@bagder
When I try to compile Curl 7.81.0 with both OpenSSL 1.0.2u and Schannel on Windows using VC14 I run into a compile error. This is my command line:
nmake /f Makefile.vc mode=static VC=14 MACHINE=x86 WITH_DEVEL=../../win32build.vc14 USE_IDN=yes WITH_SSL=dll ENABLE_SCHANNEL=yes ENABLE_NGHTTP2=yes WITH_SSH2=static WITH_ZLIB=dll GEN_PDB=yes
And this is the error:
Lines 157-163 of pem.h are these
The error occurs on the line with X509_NAME.
The error is related to this commit: c148f0f
2 possible solutions:
ENABLE_SCHANNEL=no
(but I do use the Schannel in libcurl_a.lib)I know this really is an edge case (and I can work around it), but I want to report it anyway.
The text was updated successfully, but these errors were encountered: