ngtcp2: verify the server cert on connect #8178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since quiche uses boringssl, it can probably be possible to use more or less the same code there, and possibly we can write the generic openssl certificate check code to be usable in all three places, but as a first shot the functionality should get there and only later I'll work on combining code. |
bagder
force-pushed
the
bagder/http3-ngtcp2-cacert
branch
from
eb7fb7f
to
b296c41
Compare
Make ngtcp2+quictls correctly acknowledge `CURLOPT_SSL_VERIFYPEER` and `CURLOPT_SSL_VERIFYHOST`. The name check now uses a function from lib/vtls/openssl.c which will need attention for when TLS is not done by OpenSSL or is disabled while QUIC is enabled. Possibly the servercert() function in openssl.c should be adjusted to be able to use for both regular TLS and QUIC. Ref: #8173
bagder
force-pushed
the
bagder/http3-ngtcp2-cacert
branch
from
0ed45a6
to
08bcfd8
Compare
bagder
added a commit
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes ngtcp2+quictls acknowledge
CURLOPT_SSL_VERIFYPEERandCURLOPT_SSL_VERIFYHOSTRef: #8173