check ssl_config when re-use TLS proxy connection #8141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrDwZ
changed the title
bagder
approved these changes
Dec 14, 2021
|
Sorry everyone, I merged that the wrong way with the wrong commit message. |
bagder
added a commit
that referenced
this pull request
Dec 14, 2021
|
Thanks @MrDwZ ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm following up this mail list thread, ssl_config need to be checked even when proxy_ssl_config is presented. Otherwise the destination TLS connections under the same hostname could mess up when re-use a connection and HTTPs proxy is presented with TLS-over-TLS.
I tested against some of our internal integration tests with HTTPS proxy without any issue, will see how the CI goes here.