Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift 'ignore' is now deprecated configuration option #8082

Closed
wants to merge 1 commit into from
Closed

Lift 'ignore' is now deprecated configuration option #8082

wants to merge 1 commit into from

Conversation

doddi
Copy link
Contributor

@doddi doddi commented Dec 1, 2021

Configuration for Lift has now deprecated the use of ignore and has been replaced with ignoreRules, https://help.sonatype.com/lift/configuration-reference#ConfigurationReference-in-repo-optionsIn-RepoOptions(The.lift.toml).

I noticed the recent PRs had been failing, this PR changes to the new configuration. Lift analysis is now running successfully https://lift.sonatype.com/results/github.com/doddi/curl/01FNVA0ZNPNZG9S6X1K34XFJ4R

@bagder
Copy link
Member

bagder commented Dec 1, 2021

"lift — All analyzers failed for the supported languages. Check your Lift config"

Doesn't sound like this is enough to make lift work...? (and isn't it weird that it gives this message the happy green checkmark?)

@doddi
Copy link
Contributor Author

doddi commented Dec 2, 2021

"lift — All analyzers failed for the supported languages. Check your Lift config"

Doesn't sound like this is enough to make lift work...? (and isn't it weird that it gives this message the happy green checkmark?)

I believe this is enough to make it work correctly, clicking through to the console results shows successful results https://lift.sonatype.com/result/curl/curl/01FNVBDQHRXVEFM0RY72044V3M compared to previously outright failing due to configuration issues https://lift.sonatype.com/result/curl/curl/01FNV1EGQ9DAQ6TK1WAT7ZZ7AP.

There is an outstanding issue with Lift that is currently getting looked at whereby if the master branch analysing had been failing it will unfortunately default to showing this type of message. 'All analyzers failed for the supporting languages'

@bagder
Copy link
Member

bagder commented Dec 3, 2021

Thanks!

@bagder bagder closed this in f67b4d3 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doddi @bagder