Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP3 quiche and http_version #8072

Closed
monwolf opened this issue Nov 29, 2021 · 0 comments
Closed

HTTP3 quiche and http_version #8072

monwolf opened this issue Nov 29, 2021 · 0 comments
Assignees
@bagder
Labels
HTTP/3 h3 or quic related

Comments

@monwolf
Copy link

monwolf commented Nov 29, 2021

We are starting to test http3 in our proxies and I found curl doesn't have the same behaviour when printing http_version variable.

When we do it with http/1.1:

$ docker run -it --rm --network test_network $curl curl -sk  https://usvc-ingress:1443/nginx_status -o/dev/null -w '%{http_version}\n'
1.1

If we do the same with http/3, it's empty:

$ docker run -it --rm --network test_network $curl curl -sk  --http3 https://usvc-ingress:1443/nginx_status -o/dev/null -w '%{http_version}\n'

The request is working fine with http/3:

$ docker run -it --rm --network test_network $curl curl -sk --http3 https://usvc-ingress:1443/nginx_status -i
HTTP/3 200
server: nginx
date: Mon, 29 Nov 2021 15:17:31 GMT
content-type: text/plain
content-length: 97
vary: accept-encoding
alt-svc: h3=":1443"
quic-status: quic

Active connections: 2
server accepts handled requests
 9 9 9
Reading: 0 Writing: 1 Waiting: 0

I compiled curl from sources using the versions:

ARG CURL_VERSION=curl-7_80_0
ARG QUICHE_VERSION=0.10.0

From curl -V:

$ docker run -it --rm --network test_network $curl curl -V
curl 7.80.0-DEV (x86_64-pc-linux-gnu) libcurl/7.80.0-DEV BoringSSL nghttp2/1.40.0 quiche/0.10.0
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS HSTS HTTP2 HTTP3 HTTPS-proxy IPv6 Largefile NTLM NTLM_WB SSL UnixSockets
@monwolf monwolf changed the title HTTP3 quiche and HTTP3 quiche and http_version Nov 29, 2021
@bagder bagder added the HTTP/3 h3 or quic related label Nov 29, 2021
@bagder bagder self-assigned this Dec 3, 2021
bagder added a commit that referenced this issue Dec 3, 2021
@bagder
writeout: fix %{http_version} for HTTP/3
1fa05b1 
Output "3" properly when HTTP/3 was used.

Reported-by: Bernat Mut
Fixes #8072
@bagder bagder mentioned this issue Dec 3, 2021
Closed
@bagder bagder closed this as completed in cdde541 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
HTTP/3 h3 or quic related
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

writeout: fix %{http_version} for HTTP/3 curl/curl
2 participants
@bagder @monwolf