Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl CMake script uses identifiers reserved by CMake. #7988

Closed
Boris-Rasin opened this issue Nov 10, 2021 · 1 comment
Closed

Curl CMake script uses identifiers reserved by CMake. #7988

Boris-Rasin opened this issue Nov 10, 2021 · 1 comment
Labels
cmake enhancement

Comments

@Boris-Rasin
Copy link
Contributor

From here: https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html

CMake reserves identifiers that:
    begin with CMAKE_ (upper-, lower-, or mixed-case)

Following identifiers are declared by curl CMake script (there may be more):

CMAKE_USE_SCHANNEL
CMAKE_USE_SECTRANSP
CMAKE_USE_OPENSSL
CMAKE_USE_MBEDTLS
CMAKE_USE_BEARSSL
CMAKE_USE_NSS
CMAKE_USE_WOLFSSL

I suggest changing these identifiers to use CURL_ prefix instead:

CURL_USE_SCHANNEL
CURL_USE_SECTRANSP
CURL_USE_OPENSSL
CURL_USE_MBEDTLS
CURL_USE_BEARSSL
CURL_USE_NSS
CURL_USE_WOLFSSL

curl/libcurl version

7.80.0
@jzakrzewski
Copy link
Contributor

I'm all in for the change. Just note that it'll break scripts (if any) that build curl using CMake.

bagder added a commit that referenced this issue Nov 22, 2021
@bagder
cmake: private identifiers use CURL_ instead of CMAKE_ prefix
52b8480 
Since the 'CMAKE_' prefix is reserved for cmake's own private use.
Ref: https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html

Reported-by: Boris Rasin
Fixes #7988
@bagder bagder mentioned this issue Nov 22, 2021
Closed
@bagder bagder closed this as completed in 9108da2 Nov 23, 2021
@dietssa dietssa mentioned this issue Apr 21, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: private identifiers use CURL_ instead of CMAKE_ prefix curl/curl
3 participants
@bagder @jzakrzewski @Boris-Rasin