tests: add Schannel-specific tests or disable unsupported ones #7968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mback2k
force-pushed
the
fix-schannel-tests
branch
2 times, most recently
from
3543fc6
to
157cc37
Compare
Adds Schannel variants of SSLpinning tests that include the option --ssl-revoke-best-effort to ignore certificate revocation check failures which is required due to our custom test CA certificate. Disable the original variants if the Schannel backend is enabled. Also skip all IDN tests which are broken while using an msys shell. This is a step to simplify test exclusions for Windows and MinGW.
mback2k
force-pushed
the
fix-schannel-tests
branch
from
157cc37
to
6aeae37
Compare
mback2k
changed the title
|
Works for me. Why did you add quotes to the tests field? |
|
Because a leading |
jay
approved these changes
Nov 8, 2021
MarcelRaad
approved these changes
Nov 8, 2021
|
Thanks guys. @bagder Do you think this can go in before the release or should I rather wait with this? |
bagder
approved these changes
Nov 8, 2021
|
I think they can go in before the release. |
mback2k
added a commit
to mback2k/curl
that referenced
this pull request
Nov 8, 2021
Adds Schannel variants of SSLpinning tests that include the option --ssl-revoke-best-effort to ignore certificate revocation check failures which is required due to our custom test CA certificate. Disable the original variants if the Schannel backend is enabled. Also skip all IDN tests which are broken while using an msys shell. This is a step to simplify test exclusions for Windows and MinGW. Reviewed-by: Jay Satiro Reviewed-by: Marcel Raad Reviewed-by: Daniel Stenberg Closes curl#7968
|
@bagder unfortunately it seems like I am no longer allowed to push to master, not sure what changed though: |
|
Sorry, that was me experimenting with a feature that I shouldn't have. Hopefully fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Schannel variants of SSLpinning tests that include the option
--ssl-revoke-best-effort to ignore certificate revocation check
failures which is required due to our custom test CA certificate.
Disable the original variants if the Schannel backend is enabled.
Also skip all IDN tests which are broken while using an msys shell.
This is a step to simplify test exclusions for Windows and MinGW.