Turn the Location: into a terminal hyperlink #7963
Conversation
|
Here is an example using vte. |
dfandrich
force-pushed
the
dfandrich/hyperlink
branch
from
8da1f38
to
c45cd46
Compare
dfandrich
force-pushed
the
dfandrich/hyperlink
branch
from
c45cd46
to
cbbff78
Compare
|
I tried this on five different terminal that do not support OSC 8 hyperlinks, or at least don't do anything with them (Konsole, xterm, eterm, screen, Linux console), and all of them ignored the hyperlink and displayed the text as before. It's been a while since I've looked at the ANSI spec, but I'm guessing it's using some feature of the escape sequences that's designed to be ignored by terminals that don't know about this feature. |
| } | ||
| else | ||
| fwrite(&value[1], cb - namelen - 1, 1, outs->stream); | ||
| #endif |
There was a problem hiding this comment.
maybe rather put this whole block into its own function to make it easier to deal with when glancing the code.
dfandrich
force-pushed
the
dfandrich/hyperlink
branch
from
cbbff78
to
2b74872
Compare
dfandrich
force-pushed
the
dfandrich/hyperlink
branch
from
2b74872
to
6afa157
Compare
|
I've moved the new code into a new function, as requested, and fixed the memory cleanup to use the right curl_free function. I think it's ready to be submitted now. |
|
is something messed up
…________________________________________
From: Dan Fandrich ***@***.***>
Sent: Thursday, March 10, 2022 02:48 AM
To: curl/curl
Cc: Subscribed
Subject: Re: [curl/curl] Turn the Location: into a terminal hyperlink (PR #7963)
I've moved the new code into a new function, as requested, and fixed the memory cleanup to use the right curl_free function. I think it's ready to be submitted now.
—
Reply to this email directly, view it on GitHub<#7963 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOR6DFNRTBKRJVZO7YYAAW3U7GZOBANCNFSM5HNCKKRQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This turns even relative URLs into clickable hyperlinks in a supported terminal when --styled-output is enabled. Many terminals already turn URLs into clickable links but there is not enough information in a relative URL to do this automatically otherwise.
dfandrich
force-pushed
the
dfandrich/hyperlink
branch
from
6afa157
to
c3edfa8
Compare
|
There was a compiler warning in the non-enabled case that broke some builds. I've fixed that now. |
I just learned about a new capability that terminals have gained in the last
few years, namely the ability to create clickable hyperlinks on the terminal
with arbitrary text. Many terminals already turn URLs on screen into clickable
links but there are times when curl could supply links that aren't displayed on
screen.
This PR adds the ability for curl to create hyperlinks for Location: redirects.
There is not enough information for a terminal to do this automatically for
relative URLs, but curl has enough information to do it. This is enabled when
--styled-output is turned on and a Location: header is displayed.
There are probably other cases when curl could enhance the output with links
like this, so this is mostly a proof of concept to see how easy and useful it
is. It turns out that this marginal feature takes a surprising amount of code
to accomplish due to CURLINFO_REDIRECT_URL being unavailable. I won't take it
personally if the end result is rejection this PR for a too-low
price/performance ratio.