Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check the return value of curl_url() #7917

Closed
wants to merge 1 commit into from
Closed

check the return value of curl_url() #7917

wants to merge 1 commit into from

Conversation

x2018
Copy link
Contributor

@x2018 x2018 commented Oct 28, 2021

curl_url() [lib/url.c:2396] is a memory allocation function, however, the return value of it is not properly checked.
Though curl_url_set() [lib/url.c:2402] checks it and then returns CURLUE_BAD_HANDLE, this will still confuse the proper result of parse_proxy().

bagder
bagder approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is nicer

@bagder
Copy link
Member

bagder commented Oct 28, 2021

Thanks!

@bagder bagder closed this in d55b8b6 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@x2018 @bagder