cmake: fix error getting LOCATION property on non-imported target #7885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this will be accepted? |
|
We just need someone who knows something about cmake to approve it! |
|
The docu suggests that it can be used for not IMPORTED targets but simply reading the description gives me headache. It's a mess that can go wrong quite easily and is basically only provided for compatibility, so I think this PR is a good change. |
jzakrzewski
approved these changes
Oct 28, 2021
|
Thanks, both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake allows getting LOCATION property only on IMPORTED targets:
https://cmake.org/cmake/help/latest/prop_tgt/LOCATION.html
Currently, curl cmake avoids getting LOCATION property on INTERFACE targets only.
With this change, it will avoid getting LOCATION property on all non-imported targets, not only INTERFACE targets.
This is required when both curl and zlib are built in the same CMake project (for example, when build with CMake package manager: https://github.com/scapix-com/cmodule), in which case ZLIB::ZLIB is a normal CMake target (not IMPORTED and not INTERFACE).