aws-sigv4: fix signature when post data is in binary #7844
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User sets the post fields size for binary data. Hence, we should not be using
strlen
on it.The code is very similar to the one here in mqtt.c.
I have performed basic sanity testing but do let me know if anything more is required.
Python code to create a binary test file with null character:
Build and installation:
Curl command to test:
I put a log statement (for testing) to confirm the fix: