cmake: add CURL_ENABLE_SSL option #7822
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a project building libcurl as a subproject that was trying to set
SSL_ENABLED
toOFF
to disable SSL support in libcurl. Other thanSSL_ENABLED
being set as a local variable in libcurl and basically overriding anything that they might have set in the cache, issues would have also been encountered becauseCMAKE_USE_OPENSSL
defaults toON
.I think adding an
ENABLE_SSL
option (maybe renamed to match any curl cmake option naming convention) that the various SSL backends also depend on would make it much easier for projects building libcurl as a subproject to disable ssl without needing to determine whichCMAKE_USE_*
variables for SSL backends are set, and more obvious what option needs to be turned ON/OFF.By
ENABLE_SSL
defaulting toON
, the behavior of existing SSL related options should remain the same and avoid breaking any existing ci setups or build scripts.Thoughts?