cmake: add CURL_ENABLE_SSL option #7822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRaad
reviewed
Oct 6, 2021
|
Please namespace the option. |
nightlark
force-pushed
the
add-enable-ssl-option
branch
from
2ad673c
to
3eb97df
Compare
nightlark
changed the title
|
Option name is now under the |
|
No time to test but at least looks sensible ;) |
MarcelRaad
approved these changes
Oct 14, 2021
|
The test failures look unrelated. |
|
Merged now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a project building libcurl as a subproject that was trying to set
SSL_ENABLEDtoOFFto disable SSL support in libcurl. Other thanSSL_ENABLEDbeing set as a local variable in libcurl and basically overriding anything that they might have set in the cache, issues would have also been encountered becauseCMAKE_USE_OPENSSLdefaults toON.I think adding an
ENABLE_SSLoption (maybe renamed to match any curl cmake option naming convention) that the various SSL backends also depend on would make it much easier for projects building libcurl as a subproject to disable ssl without needing to determine whichCMAKE_USE_*variables for SSL backends are set, and more obvious what option needs to be turned ON/OFF.By
ENABLE_SSLdefaulting toON, the behavior of existing SSL related options should remain the same and avoid breaking any existing ci setups or build scripts.Thoughts?