New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove leftover WinSock v1 checks #7778
Conversation
It's not supported anymore. Closes curl#7778
That's the only version we support. Closes curl#7778
WinSock 2.2 is supported by Windows CE .NET 4.1 (from 2002, out of support since 2013). Ref: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/ms899586(v=msdn.10) Closes curl#7778
bb87d95
to
e66035f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
That's the only version we support. Closes #7778
WinSock 2.2 is supported by Windows CE .NET 4.1 (from 2002, out of support since 2013). Ref: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/ms899586(v=msdn.10) Closes #7778
Thanks for the reviews and comments! |
@MarcelRaad didn't you check that all Windows CI passes at least the build stage? There are quite some compilation errors. Please take another look. |
#7788 fixes the problem I ran into after this was merged |
I actually did in my fork, and the change from #7788 is present in my local branch, just not in what landed on master and was pushed somewhere else. No idea how that could happen. Sorry about that, and thanks for the fix! |
That fix doesn’t seem to fix the compilation errors. Most Azure and Cirrus Windows CI builds still fail due to:
Maybe the old header is still needed after all? |
We require Winsock 2.2 since commit 3e4b32a,