New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pacman downloads sometimes stall after upgrading to curl 7.79.0 #7730
Labels
Comments
Can you try a patch? I immediately now spotted a mistake in that commit. diff --git a/lib/http2.c b/lib/http2.c
index a3de607c7..6d63f4363 100644
--- a/lib/http2.c
+++ b/lib/http2.c
@@ -2219,16 +2219,10 @@ CURLcode Curl_http2_setup(struct Curl_easy *data,
stream->upload_mem = NULL;
stream->upload_len = 0;
stream->mem = data->state.buffer;
stream->len = data->set.buffer_size;
- httpc->inbuflen = 0;
- httpc->nread_inbuf = 0;
-
- httpc->pause_stream_id = 0;
- httpc->drain_total = 0;
-
multi_connchanged(data->multi);
/* below this point only connection related inits are done, which only needs
to be done once per connection */
if((conn->handler == &Curl_handler_http2_ssl) ||
@@ -2250,10 +2244,16 @@ CURLcode Curl_http2_setup(struct Curl_easy *data,
conn->bits.multiplex = TRUE; /* at least potentially multiplexed */
conn->httpversion = 20;
conn->bundle->multiuse = BUNDLE_MULTIPLEX;
+ httpc->inbuflen = 0;
+ httpc->nread_inbuf = 0;
+
+ httpc->pause_stream_id = 0;
+ httpc->drain_total = 0;
+
infof(data, "Connection state changed (HTTP/2 confirmed)");
return CURLE_OK;
}
|
Seems to have fixed it! I have Many thanks! |
Primarily due to this issue, we now plan a 7.79.1 patch release for Sep 22. |
archlinux-github
pushed a commit
to archlinux/svntogit-packages
that referenced
this issue
Sep 16, 2021
curl/curl#7730 git-svn-id: file:///srv/repos/svn-packages/svn@424094 eb2447ed-0c53-47e4-bac8-5bc4a241df78
archlinux-github
pushed a commit
to archlinux/svntogit-packages
that referenced
this issue
Sep 16, 2021
curl/curl#7730 git-svn-id: file:///srv/repos/svn-packages/svn@424094 eb2447ed-0c53-47e4-bac8-5bc4a241df78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrading to curl 7.79.0 (from 7.78.0) I'm seeing connection stalls and dropouts in Arch Linux's package manager (pacman). The issue is reproducible when using Basic authentication against a HTTP/2 mirror. (It doesn't happen without Basic auth.)
Bisected this to commit 3cb8a74. I don't have a reliable reproducer yet; I used repeated
pacman -Syy
calls for testing and the issue usually occurs within the first few invocations. Eachpacman -Syy
call downloads 5 repositories concurrently (a few MiB each) using libcurl's multi interface.No tangible error messages other than
Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds
and/ortransfer closed with 5472421 bytes remaining to read
. Sorry for not providing a reproducer outside of pacman; I'll update this issue if I manage to come up with one.curl/libcurl version
operating system
Arch Linux x86_64
Linux notbad 5.14.3-arch1-1 #1 SMP PREEMPT Sun, 12 Sep 2021 20:51:34 +0000 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: