New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSSL: trace SSL3_MT_SUPPLEMENTAL_DATA #7652
Conversation
I got annoyed by seeing all those `TLSv1.2 (IN), TLS header, Unknown (23):` in the `-v` trace. So this fix is now printing: ``` * TLSv1.2 (OUT), TLS header, Supplemental data (23): ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me!
|
Effin github editor. What is leaving trailing white-space good for?
Trailing whitespace removed. Okay to Rebase and merge? |
I advice against using the UI/button for git operations because it is much harder to figure out exactly what happens and that the commit message etc is done correctly. For example, your commit message could benefit from these edits:
It is much better to squash the commit locally, edit the commit message to be fine, then merge that into the master branch and push from there to "origin/master". |
Most of these git-terms are alien to me. And it's too much hassle to clone, edit, push. Should be easier to use the Web-UI directly. |
Most of these git-terms are alien to me. And it's too much hassle to clone, edit, push. Should be easier to use the Web-UI directly.
I can push it for you with the edits requested below if you would prefer that.
|
I wouldn't mind that either. But I also want our commits and commits messages to be as good as possible, and I don't think github helps us good enough with that. |
Done. |
I got annoyed by seeing all those
TLSv1.2 (IN), TLS header, Unknown (23):
in the-v
trace.So this fix is now printing:
I hope this is a proper fix.