Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/server/*.c: align handling of portfile argument and file #7574

Closed
wants to merge 1 commit into from
Closed

tests/server/*.c: align handling of portfile argument and file #7574

wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Aug 15, 2021

  1. Call the internal variable portname (like pidname) everywhere.
  2. Have a variable wroteportfile (like wrotepidfile) everywhere.
  3. Make sure the file is cleaned up on exit (like pidfile).

Replaces #7523

@mback2k
tests/server/*.c: align handling of portfile argument and file
bb79ab6 
1. Call the internal variable portname (like pidname) everywhere.
2. Have a variable wroteportfile (like wrotepidfile) everywhere.
3. Make sure the file is cleaned up on exit (like pidfile).

Replaces curl#7523
@mback2k mback2k self-assigned this Aug 15, 2021
@mback2k mback2k marked this pull request as ready for review August 17, 2021 10:33
@mback2k mback2k requested a review from bagder August 17, 2021 10:33
@mback2k mback2k closed this in b5abbc3 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees

@mback2k mback2k

Labels
tests tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mback2k @bagder