Use a custom implementation of wcsdup on Windows, so that malloc/free… #7540
Conversation
… overrides from curl_global_init are used for wcsdup correctly.
lib/strdup.c
Outdated
| size_t lengthnul; | ||
| size_t lengthbytes; | ||
|
|
||
| if (SIZE_MAX - length < 1) |
There was a problem hiding this comment.
These overflow checks are probably unnecessary, because presumably the wchar string has a size fitting in size_t. I don't know what your standards are for checks like these.
There was a problem hiding this comment.
stdint may not be available and shouldn't be necessary. curl_setup defines SIZE_T_MAX, you can use that instead. Also Curl_wcsdup doesn't need so many lines, you can do a single check like
if(length > (SIZE_T_MAX / sizeof(wchar_t)) - 1)
return NULL;
return (wchar_t *)Curl_memdup(src, (length + 1) * sizeof(wchar_t))
Thanks! Didn't know about libcurl having a |
|
Thanks! |
… overrides from curl_global_init are used for wcsdup correctly.