Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build curl with libnghttp2 on MacOs #7514

Closed
rruipinheiro opened this issue Jul 29, 2021 · 7 comments
Closed

Can't build curl with libnghttp2 on MacOs #7514

rruipinheiro opened this issue Jul 29, 2021 · 7 comments
Labels
build HTTP/2

Comments

@rruipinheiro
Copy link

I did this

Build libnghttp2 with vcpkg and brew (didn't work).
The configure run is:

./configure --prefix=... --with-openssl=.. --with-zlib=... --with-nghttp2=... --disable-shared --enable-static --disable-ldap

Result

checking for libnghttp2 options with pkg-config... found
configure: -l is -lnghttp2
configure: -I is -I...lib/pkgconfig/../../include
configure: -L is -L...lib/pkgconfig/../../lib
checking for nghttp2_session_set_local_window_size in -lnghttp2... no
...
HTTP2:            no      (--with-nghttp2, --with-hyper)

I expected the following

HTTP2: enable (--with-nghttp2, --with-hyper)

curl/libcurl version

Host - x86_64-apple-darwin20.2.0
curl - 7.78.0-DEV
OpenSSL/1.1.1
libnghttp2 - 1.44.0
zlib - 1.2.11
bagder added a commit that referenced this issue Jul 29, 2021
@bagder
configure.ac: revert three bad nghttp2 library "fixes"
75b4d83 
This reverts commit b4b34db, 6737533 and 29c7cf7.

The logic is now back to assuming that the nghttp2 lib is called nghttp2 and
nothing else.

Reported-by: Rui Pinheiro
Reported-by: Alex Crichton
Fixes #7514
@bagder bagder mentioned this issue Jul 29, 2021
Closed
@jay
Copy link
Member

jay commented Jul 29, 2021

configure: -L is -L...lib/pkgconfig/../../lib

is this what it actually says or did you modify it? I'd expect no more than 2 dots per segment. Did you actually check the path to see if it contains the lib?

@jay
Copy link
Member

jay commented Jul 29, 2021

Nevermind, looks like I broke it. Discussion in #7515.

jay added a commit to jay/curl that referenced this issue Jul 30, 2021
@jay
configure.ac: tweak nghttp2 library name fix, yet again
8c619e4 
- Use double brackets for m4 style escape of brackets in regex.

Follow-up to b4b34db where I forgot that m4 needs brackets escaped.

Bug: curl#7400 (comment)
Reported-by: Alex Crichton

Reported-by: Rui Pinheiro

Fixes curl#7514
Closes curl#7515
@rruipinheiro
Copy link
Author

I still can't build with nghtt2p with these fixes...

@bagder
Copy link
Member

bagder commented Jul 30, 2021

@rruipinheiro are you perhaps using relative paths on the command line where you point out the locations of various paths?

@rruipinheiro
Copy link
Author

@bagder I put this '...' in my paths to not show them but I point out to the location on the installed packages folder of vcpkg. When I tried using brew I didn't provide any path location to nghttp

@bagder
Copy link
Member

bagder commented Jul 30, 2021

When configure fails to do what you expected it to, for example to find the libraries you wanted it to find, then the standard next step is to open config.log in a text editor, search for the library/test that didn't go the way you expected and see what you can figure out based on that.

We've learned that this is a very effective way and reading this file often reveals details that can take you further in debugging your build/configure issue.

@rruipinheiro
Copy link
Author

rruipinheiro commented Jul 30, 2021 •
edited

@bagder The pr #7515 worked for me! Thanks!

@bagder bagder closed this as completed in 26c002b Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build HTTP/2
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure.ac: revert three bad nghttp2 library "fixes" curl/curl
3 participants
@bagder @jay @rruipinheiro